From 80ec60a44de8664b88f3d0272d42d7269024c0e6 Mon Sep 17 00:00:00 2001
From: "vaibhav.tiwari" <249828730+vaibhavtiwari16@users.noreply.github.com>
Date: Thu, 3 Sep 2026 16:26:08 +0100
Subject: [PATCH] fix: remove record rejection from error report

---
 src/dve/pipeline/pipeline.py               |  6 +++++-
 src/dve/reporting/excel_report.py          | 11 -----------
 tests/test_pipeline/test_spark_pipeline.py |  2 --
 3 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/src/dve/pipeline/pipeline.py b/src/dve/pipeline/pipeline.py
index 234021b..a620cd5 100644
--- a/src/dve/pipeline/pipeline.py
+++ b/src/dve/pipeline/pipeline.py
@@ -852,7 +852,11 @@ def error_report(
         summary_items = er.SummaryItems(
             submission_status=submission_status,
             summary_dict=summary_dict,
-            row_headings=[e.reporting_name for e in ErrorReportCategories],
+            row_headings=[
+                e.reporting_name
+                for e in ErrorReportCategories
+                if e != ErrorReportCategories.RECORD_REJECTION
+            ],
         )
 
         workbook = er.ExcelFormat(
diff --git a/src/dve/reporting/excel_report.py b/src/dve/reporting/excel_report.py
index 5876cdd..ac9d2cc 100644
--- a/src/dve/reporting/excel_report.py
+++ b/src/dve/reporting/excel_report.py
@@ -153,17 +153,6 @@ def _add_submission_info(self, status: str, summary: Worksheet):
                 ),  # pylint: disable=C0301
             ]
         )
-        if status not in (
-            ErrorReportStatus.PROCESSING_FAILED,
-            ErrorReportStatus.FILE_REJECTION,
-        ):
-            summary.append(
-                [
-                    "",
-                    "Total Number of Records Rejected",
-                    self.submission_status.number_of_records_rejected,
-                ]
-            )
         summary.append(["", ""])
 
 
diff --git a/tests/test_pipeline/test_spark_pipeline.py b/tests/test_pipeline/test_spark_pipeline.py
index 960ad50..01e6cf8 100644
--- a/tests/test_pipeline/test_spark_pipeline.py
+++ b/tests/test_pipeline/test_spark_pipeline.py
@@ -440,9 +440,7 @@ def test_error_report_where_report_is_expected(  # pylint: disable=redefined-out
         ("File Name", "doesnotmatter"),
         ("File Extension", "json"),
         ("Total Number of Records Processed", "9"),
-        ("Total Number of Records Rejected", "2"),
         ("File Rejection", "0"),
-        ("Record Rejection", "2"),
         ("Warning", "0"),
     ]