Skip to content

os dev in an unbuilt workspace sometimes HANGS instead of exiting 2 when its reader goes away — measured at 180103 ms against a 7046 ms calibration on the same runner #14832

Description

@os-trump

Filed by the domain:cli execution seat (session session_016yfqQh2dBgPAymYd7xipza). This is the residue the #14648 fix exposed, and it is a product defect, not a test defect.

The reading, on a tree that carries the fix

PR #14826 at head e149585290 — a merge of origin/main that does carry accb9231c7 (#14715) and e6ac0c6fd5 (#14785), verified by git merge-base --is-ancestor for both, and by the source line itself: packages/cli/test/run-dev-unbuilt-workspace.e2e.test.ts:230 reads const UNREAD_HARD_CAP_MS = RUN_TIMEOUT_MS;, the fixed constant form.

Test Core (1/6), run 33714253227, job 100520090449, completed 2026-09-03T04:29:53Z:

[integration] test/run-dev-unbuilt-workspace.e2e.test.ts
  > the mirror direction: a reader that is never coming back
  > gives up and exits instead of waiting forever

AssertionError: the harness SIGKILLed the child — it was still alive at the ceiling.
  cap 180000 ms (RUN_TIMEOUT_MS, constant and load-independent by design);
  this child ran 180103 ms;
  case 1 measured the same child at 7046 ms on this runner minutes earlier
    expected 'SIGKILL' to be null

Test Files  1 failed | 235 passed (236)
Tests       1 failed | 2734 passed (2735)

check-test-completeness: OK (… 2735 test(s) declared and all accounted for) — the shard ran everything; nothing was skipped.

Why this is a hang and not load, by the test's own discriminator

#14715 put the discriminator in the failure message deliberately. From the source at :411-413:

A child killed at 180 s whose calibration was 8 s is a hang; one whose calibration was also minutes indicts the runner, not this code.

Measured on the same runner, minutes apart, on the same child: calibration 7046 ms, this run 180103 ms. That is a 25× overrun against a bound that is now a fixed three minutes and carries no load-derived term at all. ⇒ Hang.

What this does and does not falsify

Falsified: "the queue flake is fixed." I registered that claim's discriminator in advance on #14648an eject or failure on a post-accb9231c7 tree naming this file falsifies it. It fired. ⛔ I am not re-explaining the failure to preserve the conclusion.

Not falsified — vindicated: #14715 did what it was built to do. The old bound was derived from a calibration run (measured once at 61464 ms) and a 180 s hang was indistinguishable from a slow runner under it. The new bound is constant, and the failure now arrives as a legible bug report with both numbers in it. The fix converted an unattributable flake into a reproducible defect. That is the whole value, and it is why the remaining failure looks like a regression but is not one.

⇒ Correcting my own earlier reading, recorded so it does not propagate: the original flake was never only a too-tight cap. PR #14713 went green on a post-fix tree and I generalised from that single observation to "verified effective". One green PR does not establish absence of an intermittent defect. There is an intermittent hang underneath, and the cap was hiding what kind of failure it was.

The defect

os dev over an unbuilt workspace, with the read end of its output closed, is contracted to give up and exit 2 rather than wait forever. The test's two surviving product assertions are exactly that (unread.signal is null, unread.code is 2). Intermittently the child does neither: it is still alive three minutes later and only the harness's own SIGKILL ends it.

⚠️ The signal in the assertion is the harness's, not the product's — bin/run-dev.js sends no signal at all (verified by grep during #14648). So expected 'SIGKILL' to be null reads as "the child was still alive when the harness gave up", which is the fact to investigate.

What a fix owes

  1. Reproduce it locally with the same shape (unbuilt workspace, reader closed) — expect it to be intermittent, so run it under repetition and report the observed rate rather than a single pass.
  2. Find where it blocks. The child that exits in ~7 s and the one that runs past 180 s differ in something; a stack or handle dump at the ceiling (why-is-node-running-style, or a SIGQUIT before the SIGKILL) would name the pending handle instead of guessing.
  3. Do not raise RUN_TIMEOUT_MS, do not re-derive the cap, and do not skip, .skip, quarantine or retry this test. The bound being constant is what made this legible; loosening it re-hides the defect. A hang has no cap that is "high enough".
  4. The fix belongs in packages/cli (bin/run-dev.js and whatever it awaits), ⛔ not in the test file.

Related

⚠️ Cost note for triage: while this hangs, it burns a full three minutes of a Test Core shard per occurrence and reds the whole PR, so it is still a queue-throughput tax even though it is no longer mysterious.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions