fix(desktop): unblock Linux deb/rpm CI and Windows selftest hang - #97
Merged
Merged
Conversation
Linux .deb packaging failed because electron-builder requires a project homepage in package.json (FpmTarget). Add homepage + repository metadata. Windows CI hung for hours after selftest:tunnel passed: fs.rmSync on the temp userData dir threw ENOTEMPTY before app.exit(), leaving Electron alive. Close servers first, retry cleanup, and always exit via .catch(). Install rpm on ubuntu-latest so the .rpm target can invoke rpmbuild. Bump desktop to 1.0.2 for the next desktop-v* tag. Co-authored-by: Venkat SF <venkatesh.sakamuri@stayflexi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
desktop-v1.0.1workflow run 33196314686:.debbuild:Please specify project homepage(electron-builder FpmTarget)selftest:tunnelpassed but process never exited —fs.rmSyncthrewENOTEMPTYon temp dir beforeapp.exit()Fix
desktop/package.json— addhomepage+repository(required for.deb/.rpmmetadata); bump to 1.0.2desktop/scripts/tunnel-selftest.js— await server close, retry temp cleanup,.catch()→app.exit(1)so CI never hangs.github/workflows/desktop-release.yml—apt-get install rpmon ubuntu-latest (needed for.rpmtarget)Verification
Local (Linux runner equivalent):
npm test— 4/4 passxvfb-run npm run selftest:tunnel— 14/14 checks, clean exitelectron-builder --linux— AppImage + deb (amd64/arm64) + rpm built for v1.0.2After merge
Push tag to trigger installers:
git tag -a desktop-v1.0.2 -m "DeepSQL Desktop v1.0.2" git push origin desktop-v1.0.2