Skip to content

fix: remove record rejection from error report #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgeRobertson merged 1 commit into from
Sep 3, 2026
Merged

fix: remove record rejection from error report #149

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/dve/pipeline/pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -852,7 +852,11 @@ def error_report(
summary_items = er.SummaryItems(
submission_status=submission_status,
summary_dict=summary_dict,
row_headings=[e.reporting_name for e in ErrorReportCategories],
row_headings=[
e.reporting_name
for e in ErrorReportCategories
if e != ErrorReportCategories.RECORD_REJECTION
],
)

workbook = er.ExcelFormat(
Expand Down
11 changes: 0 additions & 11 deletions src/dve/reporting/excel_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,17 +153,6 @@ def _add_submission_info(self, status: str, summary: Worksheet):
), # pylint: disable=C0301
]
)
if status not in (
ErrorReportStatus.PROCESSING_FAILED,
ErrorReportStatus.FILE_REJECTION,
):
summary.append(
[
"",
"Total Number of Records Rejected",
self.submission_status.number_of_records_rejected,
]
)
summary.append(["", ""])


Expand Down
2 changes: 0 additions & 2 deletions tests/test_pipeline/test_spark_pipeline.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,9 +440,7 @@ def test_error_report_where_report_is_expected( # pylint: disable=redefined-out
("File Name", "doesnotmatter"),
("File Extension", "json"),
("Total Number of Records Processed", "9"),
("Total Number of Records Rejected", "2"),
("File Rejection", "0"),
("Record Rejection", "2"),
("Warning", "0"),
]

Expand Down
Loading