fix: Simplify Java Installation in DevContainer - #6012
Open
davem-bis wants to merge 1 commit into
Open
Conversation
…o a breaking change in the SDKMAN! API causing the previous version to fail to install. Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
davem-bis
marked this pull request as ready for review
September 2, 2026 12:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An apparent breaking change in the SDKMAN! API caused the Java DevContainer feature to fail to install.
This change removes that feature and instead installs Java via the
msopenjdk-21package.An alternate solution would have been to update the DevContainer feature, however this method appeared more robust against future changes.
Test Plan
Dev Container successfully builds and all tests run by
make fast-testsucceed.A caveat - the test
tests/core/test_context.py::test_python_model_empty_df_raisesfails when run in parallel, but passes when run sequentially. I believe this is unrelated to this change and I am fixing in PR #6013.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO