perf: reuse decoded optimized query cache entries - #6015
Draft
fresioAS wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Andreas Fredhøi <andreas.fredhoi@fresio.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoids reading and decoding the same optimized-query cache entry twice during model schema propagation.
Previously, schema processing loaded each optimized-query cache entry in a worker process to calculate the model hashes and mapping schema. After the worker completed, the parent process reopened the same gzip/pickle cache file to populate the local model's query renderer.
This change:
OptimizedQueryCacheEntryfrom the schema worker.This optimization applies independently of project-index loading. Its live performance impact will be validated separately because it trades the duplicate disk read for transfer of the decoded entry across the worker boundary.
Test Plan
Still waiting to test in live env - will update
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO