Add hidden App Doctor submit command - #8462
Draft
jek wants to merge 1 commit into
Draft
Conversation
Adds `shopify app doctor submit`, which reads the local App Doctor trace, builds a fail-closed allowlisted submission, and uploads it to App Management. The submission carries only check outcomes, finding fingerprints, redacted titles and justifications, engine and CLI versions, and a trace digest. No source code, file paths, snippets, evidence, messages, or commit identifiers are sent. The command extends BaseCommand rather than AppLinkedCommand so trace validation runs before the app is linked. It always writes `.shopify/app-doctor/submission.json` for inspection, then either stops (`--dry-run`), asks for confirmation, or uploads (`--force`). `--json` emits a single tagged result and links non-interactively. In non-interactive terminals `--force` is required unless `--dry-run` is set. Plumbing: `appRequestScanUploadUrl` and `appScanCreate` mutations with generated types, `generateScanUploadUrl`/`createAppScan` on the developer platform client, an `artifactName` label for `uploadToGCS`, and a `skipPrompts` option on `linkedAppContext`. The command is hidden, so there is no changeset. The App Management schema additions live in the gitignored local schema; codegen and the `graphql-schema` CI job will fail until Core ships the contract. Co-authored-by: AI <noreply@pi.dev> Assisted-By: devx/f000c74b-02bd-420a-abaf-487fbbbd8b3e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
shopify app doctor submit, which reads the local App Doctor trace, builds a fail-closed allowlisted submission, and uploads it to App Management. The submission carries only check outcomes, finding fingerprints, redacted titles and justifications, engine and CLI versions, and a trace digest. No source code, file paths, snippets, evidence,messages, or commit identifiers are sent.
The command extends BaseCommand rather than AppLinkedCommand so trace validation runs before the app is linked. It always writes
.shopify/app-doctor/submission.jsonfor inspection, then either stops (--dry-run), asks for confirmation, or uploads (--force).--jsonemits a single tagged result and links non-interactively. In non-interactive terminals--forceis required unless--dry-runis set.Plumbing:
appRequestScanUploadUrlandappScanCreatemutations with generated types,generateScanUploadUrl/createAppScanon the developer platform client, anartifactNamelabel foruploadToGCS, and askipPromptsoption onlinkedAppContext.The command is hidden, so there is no changeset. The App Management schema additions live in the gitignored local schema; codegen and the
graphql-schemaCI job will fail until Core ships the contract.Co-authored-by: AI noreply@pi.dev
Assisted-By: devx/f000c74b-02bd-420a-abaf-487fbbbd8b3e
WHY are these changes introduced?
Fixes #0000
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add