perf: characterize rational row-clearing allocation costs - #237
Conversation
- Add small and wide-component rational benchmark fixtures across D=2–8. - Isolate component cloning and integer scaling costs from complete determinant, sign, and solve operations. - Publish allocation and timing data with provenance and reproduction steps supporting the existing borrowed implementation. Closes #233
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (8)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 3 reviews per hour. 📝 WalkthroughWalkthroughThe change adds shared validated rational fixtures for small and wide inputs, expands exact benchmarks across input families and dimensions, adds allocation-evidence tests, updates development-tool pins, and documents benchmark scope and row-clearing measurements. ChangesRational performance evidence
Estimated code review effort: 4 (Complex) | ~45 minutes Merge Risk: ⚪ Minimal · up to The benchmark fixtures, allocation measurements, and supporting tooling changes do not leave a concrete unresolved merge risk. 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Full details: Out of Scope Changes checkExplanation The benchmark fixtures, allocation test, documentation, and allocation-counter dependency support issue
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
=======================================
Coverage 98.00% 98.00%
=======================================
Files 13 13
Lines 6579 6579
=======================================
Hits 6448 6448
Misses 131 131
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Closes #233
Summary by CodeRabbit
Performance
Documentation