engine-schema: add script to generate upgrade path changes - #14034
Draft
shwstppr wants to merge 1 commit into
Draft
engine-schema: add script to generate upgrade path changes#14034shwstppr wants to merge 1 commit into
shwstppr wants to merge 1 commit into
Conversation
Given from and to versions the script will generate the basic upgrade path changes with Java class and schema upgrade and cleanup files. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14034 +/- ##
=========================================
Coverage 19.73% 19.74%
+ Complexity 19960 19959 -1
=========================================
Files 6371 6371
Lines 575784 575784
Branches 70478 70478
=========================================
+ Hits 113659 113660 +1
Misses 449772 449772
+ Partials 12353 12352 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Adds a scaffolding script to generate a new engine-schema database upgrade path (Java upgrade class + schema/cleanup SQL files) and auto-wire it into DatabaseUpgradeChecker.java.
Changes:
- Introduces
engine/schema/create-upgrade-path.shto generate upgrade artifacts for a given from/to version. - Auto-updates
DatabaseUpgradeChecker.javaby inserting a newUpgrade<from>to<to>import and a.next(...)entry.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| IMPORT_LINE="import com.cloud.upgrade.dao.${CLASS_NAME};" | ||
| FIRST_IMPORT_LINE=$(grep -n '^import com\.cloud\.upgrade\.dao\.Upgrade' "$CHECKER_FILE" | head -1 | cut -d: -f1) | ||
| LAST_IMPORT_LINE=$(grep -n '^import com\.cloud\.upgrade\.dao\.Upgrade' "$CHECKER_FILE" | tail -1 | cut -d: -f1) | ||
|
|
Comment on lines
+138
to
+144
| awk -v first="$FIRST_IMPORT_LINE" -v last="$LAST_IMPORT_LINE" -v importfile="$SORTED_IMPORTS_FILE" ' | ||
| NR == first { | ||
| while ((getline line < importfile) > 0) print line | ||
| } | ||
| NR >= first && NR <= last { next } | ||
| { print } | ||
| ' "$CHECKER_FILE" > "$TMP_CHECKER" |
| awk -v prefix="$prefix" '{ if (length($0) == 0) print prefix; else print prefix " " $0 }' "$LICENSE_TEMPLATE" | ||
| } | ||
|
|
||
| LICENSE_JAVA="$(render_license "//")" |
Comment on lines
+89
to
+91
| cat > "$JAVA_FILE" <<EOF | ||
| ${LICENSE_JAVA} | ||
| package com.cloud.upgrade.dao; |
Comment on lines
+147
to
+152
| awk -v nextline="$NEXT_LINE" ' | ||
| /^[ \t]*\.build\(\);/ && !inserted { | ||
| print nextline | ||
| inserted = 1 | ||
| } | ||
| { print } |
Comment on lines
+153
to
+154
| ' "$TMP_CHECKER" > "$CHECKER_FILE" | ||
| rm -f "$TMP_CHECKER" |
DaanHoogland
changed the title
Contributor
|
can we change the example to 4.23.0 -> 24.0.0? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Given from and to versions the script will generate the basic upgrade path changes with Java class and schema upgrade and cleanup files.
Created #14033 changes with it.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?