Skip to content

Fixed cf-reactor --help output printing (null) for option descriptions - #6349

Open
claude[bot] wants to merge 1 commit into
masterfrom
pr-cf-reactor-help-hints
Open

Fixed cf-reactor --help output printing (null) for option descriptions#6349
claude[bot] wants to merge 1 commit into
masterfrom
pr-cf-reactor-help-hints

Conversation

@claude

@claude claude Bot commented Sep 4, 2026

Copy link
Copy Markdown

Requested by Ole Herman · Slack thread

cf-reactor --help printed (null) and misaligned descriptions because the HINTS array was missing an entry for --man, so hints after --timestamp no longer lined up with OPTIONS and the --version row hit the terminating NULL. Fixed by adding the missing "Print the man page" hint (this also fixes the option descriptions in -M man page output, which uses the same arrays).

Before:

  --man         , -M       - Output verbose information about the behaviour of the agent
  --verbose     , -v       - Output the version of the software
  --version     , -V       - (null)

After:

  --man         , -M       - Print the man page
  --verbose     , -v       - Output verbose information about the behaviour of the agent
  --version     , -V       - Output the version of the software

🤖 Generated with Claude Code

https://claude.ai/code/session_013ymkgHKqVcK7bQzGDb2rck

The HINTS array was missing an entry for the --man option, so the
descriptions of the options after --timestamp were shifted by one
and --version was printed with a (null) description.

Changelog: Title
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013ymkgHKqVcK7bQzGDb2rck
@olehermanse
olehermanse marked this pull request as ready for review September 4, 2026 18:00
@olehermanse

Copy link
Copy Markdown
Member

@cf-bottom jenkins, please

@cf-bottom

Copy link
Copy Markdown

@claude

claude Bot commented Sep 4, 2026

Copy link
Copy Markdown
Author

The macos_unit_tests failure is not caused by this PR: the diff is one help string in cf-reactor's HINTS array, which tests/unit does not exercise. The build (with -Werror) and the Linux, ASAN, and valgrind unit tests all passed on this same commit, and two unrelated PRs (#6345, #6348) failed the identical "Run unit tests" step (exit code 2) this week while other PRs passed — so this looks like an intermittent macOS unit-test failure. I don't have permission to re-run the job; a re-run should go green.


Generated by Claude Code

@olehermanse

Copy link
Copy Markdown
Member

macos unit tests failure looks unrelated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants