Skip to content

fix(hub-ui): keep grouped actions out of dock memory - #342

Merged
antfu merged 1 commit into
devframes:mainfrom
SaKaNa-Y:fix/grouped-action-memory
Sep 3, 2026
Merged

fix(hub-ui): keep grouped actions out of dock memory#342
antfu merged 1 commit into
devframes:mainfrom
SaKaNa-Y:fix/grouped-action-memory

Conversation

@SaKaNa-Y

@SaKaNa-Y SaKaNa-Y commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • stop grouped action entries from replacing the last-opened dock panel
  • ignore action IDs persisted by older clients when resolving the preferred group child
  • add regression coverage for persistence and fallback behavior

Reproduction

In the hub-ui playground, choose Ping in Playground Tools, close the group, then reopen it. Before this change, reopening reruns Ping and the group menu becomes unreachable.

Testing

  • pnpm lint
  • pnpm knip
  • pnpm test (126 files, 1447 passed, 9 skipped)
  • pnpm typecheck
  • pnpm build
  • manual before/after verification in Chrome with the hub-ui playground

@coldtea-pr-lens

coldtea-pr-lens Bot commented Sep 3, 2026

Copy link
Copy Markdown

◈ PR Lens

🟢 +0 new · 🟠 ~1 changed · 🔴 -0 removed · 0 flows · 4 files · commit 8ded031


Architecture

Architecture diagram for devframes/devframe at 8ded031

1 component touched across 1 lane.

Open full size


Data flow

No data-flow sequence changed in this PR.


Drill down
Client Runtimes & UI — 1 component
🟡 CHANGED Dock UI & Web Component

Manages dock UI rendering and state, updating selection tracking and preferred child resolution to ignore one-shot action entries in grouped docks.


View

  • Architecture lens
  • Data flow lens
  • Expand every detail
  • Show unchanged neighbours

Tip

The boxes under View are live. Tick Architecture lens or Data flow lens to choose which diagrams appear, or Expand every detail to open every drill-down at once. The comment redraws in place a few seconds later.

🪧 More tips
  • Run PR Lens on your own machine: npx skills add coldteadotai/pr-lens installs the agent skill. Then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
  • Draw a diff before it is even a pull request: npx @coldtea/pr-lens-cli analyze --base origin/main reads the diff with your own model key, and npx @coldtea/pr-lens-cli render .pr-lens/graph.json draws the same lenses on your machine.
  • Show unchanged neighbours lists the components this change did not touch alongside the ones it did, so the drill-down shows what the changed code sits next to.
  • GitHub will not let you zoom an image in a comment. The link under each diagram opens it full size on a page of its own, where you can.
  • The CLI's render picks up .github/pr-lens.yml automatically and applies your corrections (renames, exclusions, lane pins) at draw time.
  • Would you rather run it from CI on a key of your own? Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and a model key in your repository secrets, say GEMINI_API_KEY. The Action asks Gemini by default, or OpenAI and any endpoint speaking /chat/completions through its provider input.
  • PR Lens is free for open source. A star on the repository is what keeps it going.
  • Push a new commit and the whole comment re-renders for the new head. An older run never overwrites a newer one, so a slow render cannot put a stale diagram back.
  • The diagrams follow your GitHub theme, so dark mode gets the dark render and light mode the light one, and the moving dots show this pull request's data in motion.

◈ Rendered by PR Lens · crafted with ❤️ by the Coldtea team · Something drawn wrong?

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

@SaKaNa-Y is attempting to deploy a commit to the NuxtLabs Team on Vercel.

A member of the Team first needs to authorize it.

@SaKaNa-Y

SaKaNa-Y commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

Once the bug is triggered, the Playground can only be reopened via Ctrl+K. After this fix, it can be opened normally again.

@antfu
antfu merged commit dcce1ca into devframes:main Sep 3, 2026
12 of 13 checks passed
@SaKaNa-Y
SaKaNa-Y deleted the fix/grouped-action-memory branch September 3, 2026 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants