fix(code-server): open external links in new tabs - #344
Merged
Conversation
◈ PR Lens
Architecture 1 component touched across 2 lanes. Data flow No data-flow sequence changed in this PR. Drill down
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Code Server launcher opened its Installation docs and GitHub links inside the embedded iframe. Both destinations reject framing, replacing the launcher with a browser error page.
Cause
The two external ActionButton links did not specify a target, so browser navigation reused the iframe browsing context.
Fix
Verification
pnpm lintpnpm knippnpm test— 127 test files passed; 1,452 tests passed and 9 skippedpnpm typecheck— typecheck coverage passed; 39/39 tasks passedpnpm build— 27/27 tasks passed