Fix target type filter on Events page - #4253
Merged
Merged
Conversation
jvstme
approved these changes
Sep 2, 2026
jvstme
left a comment
jvstme
left a comment
Collaborator
There was a problem hiding this comment.
I've rewritten the PR to simplify it, but the overall solution looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix target type filter on the Events page
Selecting a target type on the Events page currently sends its display label to the API. For example, selecting "Instance" sends include_target_types=["Instance"], while the API expects the lowercase enum value "instance".
This keeps the display label in the UI and uses the canonical value in the request. A focused regression test covers the label/value mapping.
The focused Events test passes (4 tests), and ESLint, Prettier, and git diff --check pass. The backend test could not run in this checkout because pytest_asyncio is missing. The full frontend run still has unrelated existing failures.
For context, nightcityblade previously said they planned to work on this issue. jvstme later asked hhhhzzzj to proceed.
Fixes #4211