Skip to content

Fix macOS CI checksums and Helgrind lifecycle - #378

Merged
etr merged 2 commits into
masterfrom
fix/ci-helgrind-macos-checksums
Sep 2, 2026
Merged

Fix macOS CI checksums and Helgrind lifecycle#378
etr merged 2 commits into
masterfrom
fix/ci-helgrind-macos-checksums

Conversation

@etr

@etr etr commented Sep 1, 2026

Copy link
Copy Markdown
Owner

Summary

  • use the portable shasum -a 256 -c form for pinned libmicrohttpd downloads
  • replace the blocking-start pthread mutex/cond pair with C++20 atomic wait/notify
  • remove daemon_lifecycle pthread ownership and update its state documentation

Validation

  • local macOS build and targeted ws_start_stop / daemon_lifecycle suites pass
  • minimal Ubuntu 24.04 Valgrind reproduction reproduces the exact three CI Helgrind signatures before the lifecycle change
  • pinned libmicrohttpd checksum verifies with shasum -a 256 -c on macOS
  • GitHub Actions validation follows in this PR

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.63%. Comparing base (02bf41c) to head (41ec471).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #378      +/-   ##
==========================================
- Coverage   70.09%   69.63%   -0.47%     
==========================================
  Files          80       80              
  Lines        4237     4228       -9     
  Branches     1521     1520       -1     
==========================================
- Hits         2970     2944      -26     
- Misses        366      372       +6     
- Partials      901      912      +11     
Files with missing lines Coverage Δ
src/detail/daemon_lifecycle.cpp 54.05% <100.00%> (-1.99%) ⬇️
src/httpserver/detail/daemon_lifecycle.hpp 100.00% <ø> (ø)
src/httpserver/detail/webserver_impl.hpp 100.00% <ø> (ø)
src/webserver.cpp 59.68% <100.00%> (-0.20%) ⬇️

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02bf41c...41ec471. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@etr
etr merged commit ee9b38a into master Sep 2, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant