[GHSA-r635-g3xr-vw7x] Socket.IO: Engine.IO Polling Transport Connection Exhaustion - #9284
Open
abdelkabirouadoukou wants to merge 1 commit into
Conversation
Collaborator
|
Hi there @darrachequesne! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
github-actions
Bot
changed the base branch from
main
to
abdelkabirouadoukou/advisory-improvement-9284
September 1, 2026 06:14
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
We propose these additions, supported by the upstream fix commit:
pollingtransport and thetransports-uwsµWebSockets polling transport), since the fix patches bothpackages/engine.io/lib/transports/polling.ts(closed viares.writeHead(400).end()) andpackages/engine.io/lib/transports-uws/polling.ts(viares.writeStatus("400 Bad Request").end()).fc11285states the behavior "was introduced in engine.io@4.1.0 (January 2021)" and references commit663d326, which supports the affected lower bound of>= 4.1.0.Both changes improve the precision and reproducibility of the affected-version range and clarify the affected HTTP server implementations.