Skip mono/nuget C# integration tests on Ubuntu 26.04 - #22450
Open
redsun82 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
Review tier: Balanced
Findings: None
What changed in this PR
Updates C# POSIX integration-test selection to skip Mono/NuGet-dependent tests on Ubuntu 26.04.
Changes:
- Excludes Ubuntu 26.04 in
_supports_mono_nuget(). - Documents the Mono dependency limitation.
| File | Description |
|---|---|
csharp/ql/integration-tests/posix/conftest.py |
Adds the Ubuntu 26.04 exclusion and rationale. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
redsun82
marked this pull request as draft
August 31, 2026 13:02
Ubuntu dropped the `mono-complete` package in 26.04, and mono's own apt repository publishes nothing newer than `stable-focal`, so there is nothing to fall back on. 25.04 and 25.10 still ship it, so 26.04 is the cutoff. Without mono the legacy `packages.config` restore silently yields nothing and the buildless extractor falls back to downloading .NET Framework reference assemblies, so these four tests fail rather than being skipped. Uses the new `runs_on` version comparisons, which also lets the macOS clause collapse to `runs_on.macos < 15`. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
redsun82
force-pushed
the
redsun82-skip-mono-integration-tests-on-ubuntu-26-04
branch
from
September 1, 2026 08:59
ec313d1 to
575df8e
Compare
redsun82
marked this pull request as ready for review
September 1, 2026 08:59
Contributor
Author
|
@michaelnebel mind reapproving, now that it works with current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mono is end-of-life and its apt repository only publishes packages up to Ubuntu 18.04 (
vs-bionic). On Ubuntu 26.04 those packages are uninstallable, since their gtk2-era dependency chain (libgtk2.0-0,gnome-icon-theme,fsharp, ...) no longer resolves:Four C# integration tests need mono, and without it they fail quietly rather than obviously:
packages.configrestore needsnuget.exeunder mono, so it produces no assemblies at all andAssemblies.qlreturns an empty resultstandalone_dependencies_no_frameworkno longer finds mono's framework assemblies, so the buildless extractor falls back to downloadingmicrosoft.netframework.referenceassemblies.net481, turning 1 expected row into 242What
_supports_mono_nuget()already exists precisely to exclude platforms where mono and nuget do not work, and already excludesmacos-15/macos-26for the same class of reason. This adds Ubuntu 26.04 to it, so the four tests are deselected instead of failing.Verified by collection on both platforms (26.04 simulated by faking
freedesktop_os_release):