Fix issue_write silently dropped label errors - #3195
Merged
Conversation
Compare requested labels with the authoritative issue returned by create and update writes, and return a precise partial-failure result when GitHub omits them. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation correctly detects label mismatches and includes focused regression coverage.
Review tier: Balanced
Findings: None
What changed in this PR
Adds partial-failure detection when issue_write silently fails to apply requested labels.
Changes:
- Compares requested and returned label sets.
- Reports missing/unexpected labels with the issue URL.
- Adds focused create, update, and label-clearing tests.
| File | Description |
|---|---|
pkg/github/issues.go |
Adds label reconciliation and partial-failure responses. |
pkg/github/issues_test.go |
Tests unapplied-label scenarios without readback requests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
SamMorrowDrums
deleted the
sammorrowdrums-fix-issue-write-label-errors
branch
September 1, 2026 13:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detect when GitHub accepts an issue create or update request but omits requested labels, and return a precise partial-failure result instead of reporting success.
Why
GitHub can silently ignore labels when the caller lacks
AddLabelsToLabelablepermission while still creating or updating the issue successfully.Fixes #3160
What changed
MCP impact
issue_writenow reports partial failure when requested labels are not applied.Prompts tested (tool changes only)
Security / limits
AddLabelsToLabelableas a likely permission boundary without claiming it is the only possible cause.Tool renaming
deprecated_tool_aliases.goLint & tests
./script/lint./script/testDocs