.NET: chore: promote shipped .NET APIs - #7974
Conversation
There was a problem hiding this comment.
Pull request overview
Promotes the released WaitTimeout API from unshipped to shipped baselines for every supported .NET target framework.
Changes:
- Adds
WaitTimeoutgetter and setter to shipped API baselines. - Clears those entries from unshipped baselines.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
PublicAPI/netstandard2.0/PublicAPI.Unshipped.txt |
Removes promoted entries. |
PublicAPI/netstandard2.0/PublicAPI.Shipped.txt |
Adds shipped entries. |
PublicAPI/net9.0/PublicAPI.Unshipped.txt |
Removes promoted entries. |
PublicAPI/net9.0/PublicAPI.Shipped.txt |
Adds shipped entries. |
PublicAPI/net8.0/PublicAPI.Unshipped.txt |
Removes promoted entries. |
PublicAPI/net8.0/PublicAPI.Shipped.txt |
Adds shipped entries. |
PublicAPI/net472/PublicAPI.Unshipped.txt |
Removes promoted entries. |
PublicAPI/net472/PublicAPI.Shipped.txt |
Adds shipped entries. |
PublicAPI/net10.0/PublicAPI.Unshipped.txt |
Removes promoted entries. |
PublicAPI/net10.0/PublicAPI.Shipped.txt |
Adds shipped entries. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
MAF Automated Review — Iteration 1
Result: No findings
Scope: full PR (1 commit(s)): 550be05bf511
Model: gpt-5.6-sol
Overview
This PR mechanically promotes the existing WaitTimeout accessors from unshipped to shipped API baselines across every declared target framework without changing runtime code. The signatures remain experimental, match the implementation, and are removed from every corresponding unshipped baseline; repository validation also enforces baseline completeness and rejects remaining unshipped APIs during publishing. No publishable Critical, High, or Medium issue was established.
Reviewed the supplied pull-request change set across correctness, security/reliability, architecture, and failure behavior.
No publishable findings remained after source verification for this scope.
Code Coverage OverviewLanguages: C# C# / code-coverage/dotnetThe overall line coverage in commit 550be05 in the Show a line coverage summary of the most covered files.
|
|
Why do this feature requires PR creation access? Can we setup in such a way it doesn't and actually provide a report of what changes are needed as a message or artifact in the end of the check? |
I want to make sure we're talking about the same thing here: the coverage report integration with GitHub only requires the code quality permission, and it's working fine for now as far as I can tell. The public API export promotion needs to create a PR whenever it promotes unshipped APIs to shipped APIs (moves things from one file to another). Those are PRs like this one, except it shouldn't have been created by me, but automatically. Those PRs can be created a couple of different ways:
This what one of those automated PRs looks like with an app registration BinkyLabs/openapi-overlays-dotnet#329 (of course, the app would be different for us) Let me know if you have any additional comments or questions. |
follow up to #7935
Right now the automation is failing because a setting is not enabled at the organization level, I've made a request: