feat(cli): add unified confirmation for high-risk operations - #180
Merged
Conversation
The destructive --delete flag sat on "quota update", but the --yes high-risk confirmation guards command paths rather than individual flags. Promote it to its own "quota delete" command with a --yes guardrail, and reduce "quota update" to QPM/TPM updates only.
…at/runtime-risk-confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--yesconfirmation gateerror.type: "requires_confirmation"before authentication and business execution, while keeping confirmation failures observable in telemetry--yesautomaticallyBehavior
High-risk commands declare:
Without
--yes, the runtime stops with a structured confirmation request. After explicit confirmation, the same operation can be re-run with--yes.--dry-runremains a preview path and does not require confirmation.Additional high-risk command coverage will be added by the corresponding domain owners in follow-up changes.
Verification
vp test packages/runtime/tests packages/cli/tests/skill-risk-confirmation.test.ts: 90 passedpermission listcases returned HTTP 404 in the current credential environmentvp check: 0 errors, 3 existing warningsvp run -r build: passedBAILIAN_E2E=0 pnpm ready: check passed, but the full test phase remains blocked by 9 existing host-isolation failures where machine-level/etc/codexis detected inside fake-HOME Skill Agent tests