xppc: map inverter standby to OL - #3600
Open
user01010111 wants to merge 1 commit into
Open
Conversation
Line-interactive XPPC devices can report standBy(8) while utility power supplies the load and only the inverter is idle. Mapping that value to OFF makes upsmon treat a healthy UPS as not supplying power. Map standBy(8) to OL, clarify the inverter-versus-UPS distinction, bump the XPPC MIB version to 0.42, and document the correction. Fixes networkupstools#3512 Signed-off-by: user01010111 <lapses.50.booster@icloud.com>
|
A ZIP file with standard source tarball and another tarball with pre-built docs for commit 93b1b2f is temporarily available: NUT-tarballs-PR-3600.zip. |
|
✅ Build nut 2.8.5.5165-master completed (commit 0b696b105e by @)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3512.
Line-interactive XPPC devices can report
standBy(8)while utilitypower continues to supply the load and only the inverter is idle. The
existing
OFFmapping therefore makesupsmontreat a healthy onlineUPS as not supplying power.
This changes the mapping to
OL, clarifies the distinction betweeninverter standby and UPS/output standby, bumps
XPPC_MIB_VERSIONto0.42, and documents the correction inNEWS.adoc.Issue #3512 reports that this mapping produces
OLon utility powerand retains the expected
OB/LBtransitions on a Vertiv/Liebert PSIPS1500RT3-230. This exact candidate has not been re-tested on that
hardware, so reporter confirmation remains the runtime acceptance
boundary.
Validation
-Werror: completesnmp-upsandtop-level builds passed.
-Werror: completesnmp-upsbuild passed.
-Weverything -Werror.make stylecheckpassed.8asOLand XPPC MIBversion
0.42.make -j8 SPELLCHECK_ERROR_FATAL=no checkpassed.make SPELLCHECK_ERROR_FATAL=no distcheck-lightpassed, includingarchive, build, check, install, uninstall and distclean.
The full-driver Clang
-Weverything -Werrorprobe encountered nineexisting float-conversion diagnostics in unchanged
snmp-ups.c. Thechanged XPPC object passed that stricter probe, and the project’s
CI-style Clang build passed.
General C checklist
OLmeaning.NEWS.adocwas updated.AI assistance
OpenAI Codex
gpt-5.6-solwas used for planning, repository analysis,implementation, review, drafting and validation, including controller
and delegated work. The human contributor reviewed the change and
remains responsible for it.