ffi: include SharedArrayBuffer in error message - #65735
Open
HoonDongKang wants to merge 1 commit into
Open
Conversation
ExportBytes accepts SharedArrayBuffer inputs, but its invalid argument messages do not list SharedArrayBuffer as a supported input type. Signed-off-by: HoonDongKang <d159123@naver.com>
Collaborator
|
Review requested:
|
ShogunPanda
approved these changes
Sep 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65735 +/- ##
==========================================
+ Coverage 89.98% 90.05% +0.06%
==========================================
Files 755 755
Lines 257282 257282
Branches 48776 48797 +21
==========================================
+ Hits 231525 231700 +175
+ Misses 16841 16680 -161
+ Partials 8916 8902 -14
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExportBytes()acceptsSharedArrayBufferinputs:However, its invalid argument messages do not include
SharedArrayBufferin the list of supported input types.ExportBytes().