ext/uri: Consistency follow up to #23286 - #23551
Conversation
| --FILE-- | ||
| <?php | ||
|
|
||
| $url = Uri\WhatWg\Url::parse("foo://example.com"); |
There was a problem hiding this comment.
Was exact duplicate of host_error_forbidden_host_codepoint_special2.phpt (now host_error_colon_special.phpt); I assume the intention was to test the same as in the special tests, so I did that.
There was a problem hiding this comment.
Diff does not recognise it as rename; this is whatwg/modification/host_error_forbidden_host_codepoint_special3.phpt which is shown as deleted below. The code change is:
-$url = Uri\WhatWg\Url::parse("https://example.com");
+$url = Uri\WhatWg\Url::parse("foo://example.com");
| @@ -1,5 +1,5 @@ | |||
| --TEST-- | |||
| Test Uri\WhatWg\Url component modification - error - modifying multiple components with warnings before throwing an exception | |||
| Test Uri\WhatWg\Url component modification - error - earlier warnings not in exception | |||
There was a problem hiding this comment.
Here no method added. Although withScheme() is used this is testing that warnings aren't carried over -- so I did not see that as method specific?
| @@ -1,5 +1,5 @@ | |||
| --TEST-- | |||
| Test Uri\Rfc3986\Uri component modification - port - too small number | |||
| Test Uri\Rfc3986\Uri::withPort() - error - negative number | |||
There was a problem hiding this comment.
Elsewhere either "negative value" or "negative number" was used. Here we have (int) -1 so negative number should be correct?
This test was sourced from gh22046.phpt which first was renamed and moved, then reverted. This adjusts the naming. Part of the test is now in both. Reason: should not remove the test case here just because a bug test has it as well.
6a5e074 to
1208372
Compare
kocsismate
left a comment
kocsismate
left a comment
There was a problem hiding this comment.
looks good to me, thanks, with the only one nit below:
|
@kocsismate I just noticed that -Test Uri\Rfc3986\Uri reference resolution - parse() - absolute URI with base URI
+Test Uri\Rfc3986\Uri::parse() - success - absolute URI with base URI-Test Uri\WhatWg\Url reference resolution - resolve() - IPv4 with too many parts
+Test Uri\WhatWg\Url::resolve() - error - IPv4 with too many partsAlso noted on the nit above. |
Yes, I agree with the suggestion. |
|
Failure unrelated. |
2 participants
Depends on: #23286; as requested in #23286 (comment).
cc @kocsismate