Bugfix: console errors on unmount - #88
Open
KoolADE85 wants to merge 4 commits into
Open
Conversation
- Use modern dash[testing] version - Change component to use `className` instead of `class` - Change component to use real ref objects rather than invalid string refs
|
Looks good! |
|
Also: |
Author
but it is! 😃 : |
Oh, haha - What's it doing way up there? I always look for it near the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a flood of Javascript errors thrown when the player is unmounted while a video is playing.
While I'm in the neighbourhood:
classNameinstead of invalidclassReact.createRef()for refs instead of hard-coded stringplayerFixes #74
Fixes https://github.com/plotly/ddk-dash-docs/issues/4081