Skip to content

Bugfix: console errors on unmount - #88

Open
KoolADE85 wants to merge 4 commits into
mainfrom
bugfix/74-unmount-errors
Open

Bugfix: console errors on unmount#88
KoolADE85 wants to merge 4 commits into
mainfrom
bugfix/74-unmount-errors

Conversation

@KoolADE85

@KoolADE85 KoolADE85 commented Aug 31, 2026

Copy link
Copy Markdown

This PR fixes a flood of Javascript errors thrown when the player is unmounted while a video is playing.

While I'm in the neighbourhood:

  • move CircleCI job to a Github action
  • update dev dependencies to a modern stack
  • fix trivial console errors around invalid React syntax:
    • use className instead of invalid class
    • use React.createRef() for refs instead of hard-coded string player

Fixes #74
Fixes https://github.com/plotly/ddk-dash-docs/issues/4081

- Use modern dash[testing] version
- Change component to use `className` instead of `class`
- Change component to use real ref objects rather than invalid string refs
@AnnMarieW

AnnMarieW commented Aug 31, 2026

Copy link
Copy Markdown

Looks good!
Just curious - why is react-player not listed as a dependency in package.json

@AnnMarieW

Copy link
Copy Markdown

Also:
closes #78

@KoolADE85

Copy link
Copy Markdown
Author

Looks good! Just curious - why is react-player not listed as a dependency in package.json

but it is! 😃 :

@AnnMarieW

Copy link
Copy Markdown

Looks good! Just curious - why is react-player not listed as a dependency in package.json

but it is! 😃 :

Oh, haha - What's it doing way up there? I always look for it near the devDependancies. I totally missed it! 🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error at Chrome Console

2 participants