Allow more than 9 subsecond digits in ISO 8601 parsing - #1002
Open
mturac wants to merge 1 commit into
Open
Conversation
The subsecond regex group only accepted 1-9 digits, so timestamps with higher precision (e.g. from .NET or database drivers that emit 10+ fractional digits) raised a ParseError. Widen the pattern to accept any number of digits. The processing code already truncates to 6 digits for microseconds, so the change is safe.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #935.
the ISO 8601 regex for subsecond digits was
\d{1,9}, so anything with more than 9 fractional digits raised a ParseError. some systems (.NET, certain database drivers, high-precision scientific instruments) regularly emit 10+ digits.the fix just widens the capture group to
\d+. the code that reads the match already does[:6]to truncate to microseconds, so no other changes needed.tested with timestamps from 1 to 13 fractional digits, with and without timezone offsets. existing tests unaffected.