gh-64862: Use iter() with stop_exception in the stdlib - #156770
Open
serhiy-storchaka wants to merge 1 commit into
Open
gh-64862: Use iter() with stop_exception in the stdlib#156770serhiy-storchaka wants to merge 1 commit into
serhiy-storchaka wants to merge 1 commit into
Conversation
Replace hand-written loops which drain a container or a queue. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
serhiy-storchaka
requested review from
FFY00,
brettcannon,
ericsnowcurrently,
gpshead,
kumaraditya303,
ncoghlan and
warsaw
as code owners
September 1, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace hand-written loops which drain a container or a queue with
iter(callable, stop_exception=...), added in GH-156298.All of them except
XMLPullParser.read_events()already caught the exception raised by the exhausted container;read_events()tested the queue for emptiness before popping from it, which is also one step less atomic.Loops which drain a small container are left as they are: raising and catching the exception costs about 100 ns, which only pays off above ~35 items (measured on a PGO build; the per-item cost of the exception form is ~19% lower, because it does not test the container in every iteration).