gh-156774: Speed up pdb startup with asyncio guard - #156775
Open
brittanyrey wants to merge 3 commits into
Open
Conversation
Defer the eight imports that are not already pulled in by pdb's required-eager imports (cmd, bdb, code, typing and the guarded _pyrepl.utils), and lift five unguarded function-level imports to module-scope lazy imports. Guard Pdb._get_asyncio_task() on 'asyncio' in sys.modules. It runs on every interaction(), so without the guard the deferred asyncio import is paid back immediately on the first breakpoint and the lazy import buys nothing for an actual debugging session. If asyncio was never imported there cannot be a running task, so returning None is equivalent. The guarded imports (readline, rlcompleter, _pyrepl) stay function-level: they sit in try/except ImportError blocks, and hoisting them would move the failure outside the guard. import pdb -42.1% breakpoint() -> cont -41.1% python -m pdb script -33.4% pdb post-mortem -33.3%
Member
|
See #156567 for the lazy imports, your review welcome! I was planning on doing the asyncio guard as a followup :) Shall we reduce this PR to just that? |
Contributor
Author
|
Sorry about that! I did a peek over the lazy imports label & missed your issue! I'm glad to scope this down to just the asyncio gated change. |
brittanyrey
changed the title
Drop the other lazy imports and the lifted function-level imports, leaving just the asyncio deferral and the _get_asyncio_task() guard. Those two carry most of the win and keep the diff to five lines. import pdb -28.8% (was -42.1% with the full set) breakpoint() -> cont -28.5% python -m pdb script -26.0% pdb post-mortem -24.6%
Contributor
Author
|
PR + issue are fully rescoped @hugovk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
perf
Broken out impact of lazy imports + asyncio guard
Without it, only the initial import really improves:
import pdbbreakpoint()→ continuepython -m pdb script