gh-153740: refine test for _Float16 (check support from libm) - #156815
gh-153740: refine test for _Float16 (check support from libm)#156815skirpichev wants to merge 2 commits into
Conversation
deebbb7 to
0567678
Compare
|
!buildbot freebsd |
|
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 0567678 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156815%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
I tested your change manually on FreeBSD: it works as expected.
Please update the comment to explain why you test isinf(). You can do that once the buildbot completes.
| int main(void) | ||
| { | ||
| _Float16 val = 1.0f16; | ||
| int test = !isfinite(val) || isinf(val) || isnan(val); |
There was a problem hiding this comment.
Please complete # Check for native half-float type (_Float16). comment to explain why you test these function calls. Something like:
# Check for native half-float type (_Float16).
# Check also for isinf(_Float16): it's not supported on FreeBSD 15.
Yes, failures on buildbots looks unrelated.
I've added inline comments on test. We don't use anything beyond isinf/isnan from the libm, so I think it's fine. |
|
!buildbot FreeBSD14 |
|
🤖 New build scheduled with the buildbot fleet by @skirpichev for commit 8daf2de 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F156815%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
3 participants
Uh oh!
There was an error while loading. Please reload this page.