Skip to content

docs: clarify ignore cleanup in migration skill #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Sep 2, 2026
Merged

docs: clarify ignore cleanup in migration skill #455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .agents/skills/migrate-to-rstack-cli/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,12 @@ Read every matching reference before editing. Load only the tools present in the

Rsbuild, Rslib, Rstest, Rslint, and Prettier remain transitive `rstack` dependencies. Remove obsolete direct dependencies and imports from the migrated scope; do not expect their names to disappear from the lockfile.

### Ignore cleanup

After migrating lint or formatting, remove exclusions from lint `ignores` and fmt `ignorePatterns` when the same paths are already covered by effective `.gitignore` rules; both commands read `.gitignore` automatically. For fmt, also remove `package-lock.json` and `pnpm-lock.yaml` from `ignorePatterns`; `rs fmt` ignores them by default.

Keep negations and fmt exclusions that must apply to explicitly passed files, which bypass `.gitignore`.

### Combined checks

After migrating lint and formatting commands, prefer the shorter combined command when behavior is equivalent:
Expand Down
2 changes: 0 additions & 2 deletions .agents/skills/migrate-to-rstack-cli/references/prettier.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,6 @@ Read this reference when the project uses the `prettier` CLI or API, `package.js
8. Delete old config and ignore files only after their behavior is represented in `define.fmt`.
9. Remove direct dependencies only when no script, config, API call, plugin peer requirement, or other tool still needs them.

`rs fmt` ignores `package-lock.json` and `pnpm-lock.yaml` by default. Drop redundant ignore entries during migration, but keep intentional negations.

Rstack creates `.rstack/cache/.gitignore` by default. Do not list `.rstack/cache` in the root `.gitignore`; add explicit rules only for custom cache paths.

`rs fmt` does not read Prettier configuration files, `.prettierignore`, or `.editorconfig`.
Expand Down