chore(openspec): archive signature-coverage-statement - #248
Merged
Conversation
#247 merged the change and never took its tip step, so the statement it exists to make lived in a change directory and not in the spec. Archiving is what promotes a delta into `openspec/specs/`, which means until now `cli-rule-reconciliation` did not carry the coverage rule we declined the generator team's per-file signature proposal on the strength of writing down. All four scenarios survive the promotion, including the two that were nearly dropped in review: parameter-parsing order and whole-string comparison. Nothing checks for this in either direction, which is how #246 came to be outstanding too. A single-PR change has no later slice to carry the archive, so it has to happen on the same PR or immediately after.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#247 merged
signature-coverage-statementand never took its tip step.That matters more than a tidy-up, because archiving is what promotes a delta into the standing spec. Until this lands, the statement the change exists to make is not in
openspec/specs/cli-rule-reconciliation/spec.md:We declined the generator team's per-file signature proposal on the strength of writing this down instead, and told them so. It was not written down.
What lands
Canonical rule signature envelopegains:plus the scenario
A v1 signature covers the engine's rule file.All four scenarios survive the promotion, verified after archiving — including the two that were nearly dropped in review (
Version is read before parameters,Signatures compare as whole strings).openspec validate --specs --strictpasses across all 26 specs.Why this keeps happening
Nothing checks archive state in either direction, by design: a PR-time gate had to guess at stack position, and the
main-only replacement turnedmainred for as long as a forward-merging stack took to drain.The gap that remains is the single-PR change, which has no later slice to carry the archive. #246 was the same omission on a stacked change; this is the single-PR version. Both were found by a person noticing, which is the thing the removed gates were supposed to replace and did not.
No code. Every path is under
openspec/.