cli: report the device that actually ran in --json output - #36
Merged
Conversation
A run requested with a wildcard or partial device name ("*", "iPhone")
showed that request as the device in --json, which is useless in a
report. Prefer the environment the run executed on, falling back to the
capability when it is not yet known.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while building the GitHub Action: a run requested with
--device '*'reported"device": { "name": "*" }in--json. The JSON now uses the environment the run executed on (environment.device/version), falling back to the requested capability while the run has not been allocated yet.Test plan