Skip to content

Improve the Vercel & Slack integration settings pages - #4848

Merged
samejr merged 7 commits into
mainfrom
samejr/castries
Sep 1, 2026
Merged

Improve the Vercel & Slack integration settings pages#4848
samejr merged 7 commits into
mainfrom
samejr/castries

Conversation

@samejr

@samejr samejr commented Aug 31, 2026

Copy link
Copy Markdown
Member

What

Updated layout for the Vercel and Slack organization integration settings pages to match the rest of the settings UI. Layout & UI only — no loader/action/logic changes.

Blank states (no integration)

  • Added the app title bar (it was missing on the Vercel page)
  • Centered logo + heading + copy, with the two pages mirroring each other
  • A project picker CTA that deep-links to where each integration is configured for the chosen project — Vercel → the project's integrations page; Slack → the Errors page alerts sheet (?alerts=true) — styled like the side-menu project switcher

Connected states

  • Rebuilt on SettingsContainer / SettingsSection / SettingsHeader / SettingsRow
  • An Overview section with detail rows + a Remove integration row (confirmation dialog kept)
  • A connected projects / alert channels table that fits the settings column
  • Vercel: copyable Team/Installation IDs (CopyableText), a sticky Configure cog action per row
  • Slack: mirrors the same layout (Workspace / Installed / Remove + alert channels table)
CleanShot 2026-08-31 at 10 47 37 CleanShot 2026-09-01 at 19 40 18@2x CleanShot 2026-09-01 at 19 40 28@2x

🤖 Generated with Claude Code


Open workspace in Conductor

samejr and others added 2 commits August 31, 2026 08:13
- Add the app title bar (NavBar) to the Vercel integration page, which
  was missing it
- Restyle the Vercel blank state to line up with the Settings pages
  (centered icon, heading and dimmed copy)
- Add a shared ProjectConnectSelect CTA to both blank states: a project
  menu (styled like the side menu's project switcher) that deep-links to
  where each integration is configured for the chosen project
  (Vercel -> project integrations page; Slack -> Errors page alerts sheet)

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…the Settings layout

Port both integration pages' connected states onto the shared Settings
components (SettingsContainer/Section/Header/Row) used across the settings
pages, so they match the account/org settings look:

- An "Overview" section with detail rows and a "Remove integration" row
- A connected projects / alert channels table that fits the settings column

Vercel also gets copyable Team/Installation IDs, a project picker styled
like the side-menu project switcher, and a sticky "Configure" cog per row.
Slack mirrors the same layout (Workspace/Installed/Remove + channels table).

Also add a 500ms hover delay to the shared DateTime tooltip.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Aug 31, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 97cebf5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 6c083fa2-03cf-43b2-a5f3-1f9e54a57a4a

📥 Commits

Reviewing files that changed from the base of the PR and between 97e3f0a and 97cebf5.

📒 Files selected for processing (4)
  • apps/webapp/app/components/integrations/ProjectConnectSelect.tsx
  • apps/webapp/app/components/primitives/DateTime.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.slack.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.vercel.tsx
🚧 Files skipped from review as they are similar to previous changes (4)
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.slack.tsx
  • apps/webapp/app/components/integrations/ProjectConnectSelect.tsx
  • apps/webapp/app/components/primitives/DateTime.tsx
  • apps/webapp/app/routes/_app.orgs.$organizationSlug.settings.integrations.vercel.tsx

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


Walkthrough

Added a reusable project selector for integration configuration navigation. Updated Slack and Vercel integration pages to use shared settings layouts and project-based empty states. Added copyable identifiers, date displays, redesigned removal controls, and icon-based Configure actions. Added a 500ms delay to date tooltips.

Merge Risk: ⚪ Minimal · up to 97ceb

This PR updates the Vercel and Slack integration settings layouts without changing integration logic, so no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the main change: improving the Vercel and Slack integration settings pages.
Description check ✅ Passed The description provides a detailed summary of the UI changes, affected states, and screenshots. It does not include the template's issue link, checklist, testing steps, or changelog sections, but the…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description provides a detailed summary of the UI changes, affected states, and screenshots. It does not include the template's issue link, checklist, testing steps, or changelog sections, but the core change description is complete.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch samejr/castries

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

devin-ai-integration[bot]

This comment was marked as resolved.

coderabbitai[bot]

This comment was marked as resolved.

samejr and others added 3 commits August 31, 2026 10:38
The icon-only Configure link had no text or aria-label, so screen readers
announced an unnamed link. Add aria-label="Configure <project>".

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ngs tweaks

These are UI/layout-only refinements to existing settings pages; not worth a
changelog entry.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
devin-ai-integration[bot]

This comment was marked as resolved.

@pkg-pr-new

pkg-pr-new Bot commented Sep 1, 2026

Copy link
Copy Markdown

Open in StackBlitz

@trigger.dev/build

npm i https://pkg.pr.new/@trigger.dev/build@a48fd40

trigger.dev

npm i https://pkg.pr.new/trigger.dev@a48fd40

@trigger.dev/core

npm i https://pkg.pr.new/@trigger.dev/core@a48fd40

@trigger.dev/python

npm i https://pkg.pr.new/@trigger.dev/python@a48fd40

@trigger.dev/react-hooks

npm i https://pkg.pr.new/@trigger.dev/react-hooks@a48fd40

@trigger.dev/redis-worker

npm i https://pkg.pr.new/@trigger.dev/redis-worker@a48fd40

@trigger.dev/rsc

npm i https://pkg.pr.new/@trigger.dev/rsc@a48fd40

@trigger.dev/schema-to-json

npm i https://pkg.pr.new/@trigger.dev/schema-to-json@a48fd40

@trigger.dev/sdk

npm i https://pkg.pr.new/@trigger.dev/sdk@a48fd40

commit: a48fd40

samejr and others added 2 commits September 1, 2026 18:40
…ngs changes

Strips the code comments this branch added across the Vercel/Slack integration
settings pages and the shared ProjectConnectSelect. Keeps the functional
oxlint-disable directive; leaves pre-existing loader/action comments untouched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@samejr
samejr added this pull request to the merge queue Sep 1, 2026
Merged via the queue into main with commit 755feb2 Sep 1, 2026
52 checks passed
@samejr
samejr deleted the samejr/castries branch September 1, 2026 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants