-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
perf(clickhouse): stop storing native event attributes #4866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+64
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions
21
internal-packages/clickhouse/schema/042_reduce_task_events_v2_storage_overhead.sql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| -- +goose Up | ||
|
|
||
| -- Full-text search is served outside the source event table. Keeping these | ||
| -- indexes here adds work to every event insert and merge without serving reads. | ||
| ALTER TABLE trigger_dev.task_events_v2 | ||
| DROP INDEX IF EXISTS idx_attributes_text_search; | ||
|
|
||
| ALTER TABLE trigger_dev.task_events_v2 | ||
| DROP INDEX IF EXISTS idx_message_text_search; | ||
|
|
||
| -- attributes remains an insert input for attributes_text, but is no longer | ||
| -- stored. Writers must include attributes in an explicit insert column list | ||
| -- because implicit INSERT column lists exclude EPHEMERAL columns. | ||
| ALTER TABLE trigger_dev.task_events_v2 | ||
| MODIFY COLUMN attributes JSON EPHEMERAL; | ||
|
carderne marked this conversation as resolved.
|
||
|
|
||
| -- +goose Down | ||
|
|
||
| -- Restoring the stored JSON column safely requires inspecting the live schema | ||
| -- and coordinating the writer rollback. Use a new forward migration instead. | ||
| SELECT throwIf(1, 'This migration cannot be rolled back automatically'); | ||
|
carderne marked this conversation as resolved.
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.