fix(gateway): align land strategy mapping with contract - #663
Draft
sbalabanov wants to merge 1 commit into
Draft
Conversation
Summary: Intent: - Preserve server-configured defaults instead of forcing rebase at the gateway boundary. - Support every merge strategy exposed by the shared API contract. Changes: - Map DEFAULT to the domain sentinel so downstream Runway configuration selects the strategy. - Map PROMOTE to its domain strategy while continuing to reject unknown numeric enum values. - Extend mapper coverage for default and promote behavior. --- <sub>Generated by the 🪄 pr-create skill.</sub>
|
|
sbalabanov
commented
Sep 2, 2026
| case mergestrategypb.Strategy_DEFAULT: | ||
| // TODO: resolve default strategy based on queue configuration | ||
| return mergestrategy.MergeStrategyRebase, nil | ||
| return mergestrategy.MergeStrategyUnknown, nil |
Contributor
Author
There was a problem hiding this comment.
do not change that, restore Rebase and TODO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Intent:
Changes:
Generated by the 🪄 pr-create skill.
Test Plan
Issues