fix: Resolve test collisions when capsys used - #6013
Open
davem-bis wants to merge 2 commits into
Open
Conversation
4 tasks
Signed-off-by: davem-bis <68955845+davem-bis@users.noreply.github.com>
davem-bis
force-pushed
the
feature/DRM/resolve-test-collisions-in-parallel-run
branch
from
September 2, 2026 12:56
267388d to
85c40c3
Compare
davem-bis
marked this pull request as ready for review
September 2, 2026 13:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Tests that use capsys can collide with each other as capsys is not threadsafe.
I have modified
conftest.pyto apply theisolatedpytest marker (so they tests run sequentially) ifcapsysis passed to the test.Test Plan
make fast-testpasses.PyTest correctly flags tests that use capsys as marked with
isolated:Note that
test_python_model_empty_df_raisesdoes not have theisolatedmarker applied to it directly, it is dynamically added by the changes to conftest.Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO