Support document-selected avatar appearances alongside the humanoid rig - #124
Support document-selected avatar appearances alongside the humanoid rig#124edib wants to merge 4 commits into
Conversation
|
@edib is attempting to deploy a commit to the johndoe's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@edib I prepared and validated the follow-up fixes here: edicate#1 Because #124 has maintainer edits disabled, please merge that draft PR into The follow-up separates avatar appearance from Validation passed: 463 tests, typecheck, production/package builds, package checks, and 1620/1620 movement eval checks. One blocker still needs your input before merge: please confirm the source/license provenance for avatar2 and avatar3 so the correct third-party notice can be added. |
Harden avatar selection and loading for posecode#124
|
@edib Thanks for merging the hardening follow-up. To clear the remaining asset-license blocker, could you please reply with the following for both
The files' embedded metadata identifies Blender/glTF tooling but does not identify the creator or redistribution terms. Once these details are available, we can add an accurate |
|
I prepared a follow-up that keeps the avatar-selection feature while removing the two bundled GLBs whose redistribution provenance has not been established: The follow-up:
Verification is green: 463 tests, package builds, full typecheck, playground production build, package validation, and @edib, please merge the follow-up into your |
|
Status from a maintainer sweep of the open PRs:
Note that |
|
Landed on This PR could not be merged directly: its required Two things were resolved on the way in:
Thanks for the contribution. |
Description
Add document-selected character appearances without changing Posecode's skeleton topology.
rigremainshumanoid; an optionalavatar avatar1|avatar2|avatar3directive selects a character through the renderer'scharacterUrlsmap. Documents withoutavatarcontinue to use the humanoid default.Character load failures and unmapped selectors always restore the procedural mannequin, so an unavailable asset cannot leave the scene blank.
What changed
avatardirective and IR field while keepingrig humanoidas the only rig topology.characterUrlsselection while preserving fixedcharacterUrlprecedence. Character swaps use latest-request-wins semantics, dispose stale async loads, allow retry after failure, reset clip state safely, and restore the procedural fallback.characteruses document-driven selection; an explicit GLB URL still pins one character andcharacter="off"still disables skinned characters.avatar1intentionally reuses the existing XBot instead of committing a duplicate.avatar2.glbandavatar3.glbare included; avatar3 was reduced from about 35 MB to 7.4 MB.1.0.0.Validation
Validated again against the current
mainmerge result:npm test— 47 test files, 463 tests passednpm run typechecknpm run buildnpm run build:packagesnpm run check:packagesnpm run changeset -- status— minor release, no accidental major bumpnpm run eval— 1620/1620 checks across 77 movementsRequired before merge
avatar2.glbandavatar3.glb, then add the appropriate entry todocs/legal/THIRD_PARTY_NOTICES.md. The GLB metadata alone is not sufficient to establish provenance.