Support document-selected avatar appearances alongside the humanoid rig - #130
Merged
Conversation
Harden avatar selection and loading for posecode#124
avatar2.glb and avatar3.glb are Adobe Mixamo exports (the Beta and Remy characters): both carry the mixamorig: skeleton, a mixamo.com animation track, and Mixamo mesh and texture names. List them alongside xbot.glb so the existing Mixamo posture covers every committed character, and sync package-lock.json with the 0.4.3 workspace versions.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands the avatar work from @edicate's #124 on top of current
main.#124 could not be merged from the fork: its required
Vercelstatus check is red only because fork preview deployments are unauthorized, the branch protection uses a strict up-to-date policy, andmaintainerCanModifyis off so the branch could not be updated. This branch merges the original commits into currentmainwith their authorship intact, so the contribution is credited to the original author. Merge this with a merge commit, not squash, or that authorship is collapsed.What changed relative to #124
main(0.4.3, Node 24 CI,changesets/action@v2) withpackage-lock.jsonresynced to the 0.4.3 workspace versions.mixamorig:skeleton, amixamo.comanimation track, and Mixamo mesh/texture names (Beta_Joints/Beta_Surface,Remy_Body_*). They are Adobe Mixamo's Beta and Remy characters, the same category as the already-committedxbot.glb.docs/legal/THIRD_PARTY_NOTICES.mdanddocs/legal/LEGAL_REVIEW.mdnow list them.Documenting the assets does not by itself make them redistributable; it brings them under the Mixamo posture the repository already carries for
xbot.glb, andLEGAL_REVIEW.mdstill calls for rechecking the Adobe terms.Validation
npm run build:packages,npm run typecheck,npm run check:packages,npm run build— passnpm test— 47 files, 463 tests passnpm run eval— 1620/1620 checks, 0 parse failuresnpx changeset status— minor bump, no accidental majorCloses #124